ACF Wysiwyg Editor Visual Tab Not Clickable With Site Kit Activated

[RamseyV]

Bug Description

When making a new post or page, the "Visual" tab of an acf wysiwyg editor is not clickable. All of the clickable options at the top of the editor are no longer there. This only happens when Site Kit is activated.

Steps to reproduce

1. Activate advanced custom fields and site kit (On a WordPress 4.9 or below install)
2. Create a new post and add an acf wysiwyg editor to the page.
3. The "Visual" tab will not be clickable. The "Text" tab is selected (which isn't default) and it cannot be changed.

Screenshots

Here is what it looks like when Site Kit is not activated:

Here is what it looks like when Site Kit is activated:

Additional Context

This has been tested on multiple different devices and operating systems, all with the same result. It has been isolate by removing all plugins except for ACF and Site Kit.

Wordpress Version: tested on 4.9.9 and 5.3 ACF Version: Advanced Custom Fields Pro 5.5.14

• PHP Version: affected on multiple version of 7.1. and 7.2.
• OS: [e.g. iOS] served OSX 10.14.6 and Linux (Amazon Linux 2), tested with OSX and Windows 7 & 10
• Browser [e.g. chrome, safari] Chrome, Safari, Firefox
• Plugin Version [e.g. 22] multiple versions from 1.0.4-beta to 1.1.2
• Device: [e.g. iPhone6] Macbook Pro, Windows 7 & 10 machines

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Changelog entry

[jamesozzie]

@RamseyV I am unable to recreate the same issue after testing on 2 different sites. Can you check with another site and minimal plugins active and from a browser incognito window?

[RamseyV]

I just tried with a new install of wordpress 4.9.9, connected to a fresh database, no other plugins activated, and the Twenty Seventeen theme activated (Askimet Anti-Spam and Hello Dolly are installed but not activated). The only plugins activated are Site Kit 1.1.12 and Advanced Custom Fields PRO 5.5.14 and I am still getting the same bug.

System Specs: OSX 10.14.6 PHP 7.2.1 MySQL 5.6.38 PHP and MySQL hosted by MAMP 4.5

Note: I used composer to install the plugins before, this time I just uploaded the zip files from the wordpress admin console.

[RamseyV]

I just tested in WordPress 5.3 and it is working. This seems to only be an issue in WordPress 4.9, but I have not tested this in any other versions.

[jamesozzie]

@RamseyV Thanks for the update and additional checks. For WordPress 4.9 or previous versions I will check with the team or install the Gutenberg plugin and check for compatibility.

[jamesozzie]

@RamseyV Just following up with you on this issue. I've tried to recreate the same issue using WordPress 4.8 and the ACF wysiwyg visual button is working as expected using the free version. Are you still using and post 5.0 version of WordPress which you can test with?

[jamesozzie]

@RamseyV Just checking if this issue persists from your side. If so can you please share any console errors you encounter in order to share with the team?

[RamseyV]

I am no longer getting this issue. Thanks!