Open zutigrm opened 1 week ago
Thanks @zutigrm AC ✅ Moving to IB and I'll pick this up.
Thanks @10upsimon IB ✅
Can you assign me this issue?
Did a check and here are my observations:
ITEM 1: There was an extra 24px spacing for the Plugin Status section: between the text description and the 'Reset Sitekit' CTA. Based on figma, it's only 24px.
ITEM 2: This feels out of scope and might not even be an issue but on Figma, for the 'Plugin Settings' involves a toggle. However in our current implementation, it's a checkbox. Let me know if this needs a separate ticket.
Other than that, the borders are not appearing, which is as expected.
@kelvinballoo thank you. I have just pushed a PR that addresses the margin on the Reset Site Kit CTA text. The checkbox vs radio controls can be ignored as part of this issue.
Feature Description
Borders should be removed from bellow the section titles in the admin settings, and any other edits if needed - like spacing, etc. Figma design can be found here
Currently, boxes with borders:
New design without borders:
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
assets/sass/components/settings/_googlesitekit-settings-admin.scss
admin.scss
file atassets/sass/admin.scss
, within the// Settings
import group..googlesitekit-plugin #js-googlesitekit-settings
and within it:.googlesitekit-layout__header
and remove the boarder, and within it:.mdc-layout-grid
and remove the bottom padding, and within it:h3.googlesitekit-layout__header-title
and set the following CSS properties:font-family: $f-primary;
font-weight: $fw-medium;
font-size: $fs-title-lg;
Test Coverage
QA Brief
Site Kit > Settings > Admin Settings
Changelog entry