google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 291 forks source link

Remove title borders from Admin Setting Sections #9580

Open zutigrm opened 1 week ago

zutigrm commented 1 week ago

Feature Description

Borders should be removed from bellow the section titles in the admin settings, and any other edits if needed - like spacing, etc. Figma design can be found here

Currently, boxes with borders:

image.png

New design without borders: Image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

10upsimon commented 1 week ago

Thanks @zutigrm AC ✅ Moving to IB and I'll pick this up.

zutigrm commented 1 week ago

Thanks @10upsimon IB ✅

Aditya-PS-05 commented 6 days ago

Can you assign me this issue?

kelvinballoo commented 1 day ago

QA Update ⚠

Did a check and here are my observations:

ITEM 1: There was an extra 24px spacing for the Plugin Status section: between the text description and the 'Reset Sitekit' CTA. Based on figma, it's only 24px.

Implementation: 48px ![Image](https://github.com/user-attachments/assets/911364a1-20c8-41b7-8b9e-a67bb8f50ae4) Figma: 24px: ![Image](https://github.com/user-attachments/assets/5bc14c91-ae10-41c4-bae4-5e1fb2135346)

ITEM 2: This feels out of scope and might not even be an issue but on Figma, for the 'Plugin Settings' involves a toggle. However in our current implementation, it's a checkbox. Let me know if this needs a separate ticket.

Implementation: ![Image](https://github.com/user-attachments/assets/47757170-101a-4bd1-8c77-586921123737) Figma: ![Image](https://github.com/user-attachments/assets/c258f9fd-4351-4124-82d4-887aff25f03d)

Other than that, the borders are not appearing, which is as expected.

![Image](https://github.com/user-attachments/assets/37720f7a-ed40-43a8-9fa5-111e2ac4aa8a)
10upsimon commented 14 hours ago

@kelvinballoo thank you. I have just pushed a PR that addresses the margin on the Reset Site Kit CTA text. The checkbox vs radio controls can be ignored as part of this issue.