Issue / 9439 Logic to Trigger Old vs New Conversion Metrics Modal

10upsimon commented 6 days ago

Summary

Addresses issue:

9439

Relevant technical choices

PR Author Checklist

[x] My code is tested and passes existing unit tests.
[x] My code has an appropriate set of unit tests which all pass.
[x] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
[x] My code follows the WordPress coding standards.
[x] My code has proper inline documentation.
[x] I have added a QA Brief on the issue linked above.
[x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

[ ] Run the code.
[ ] Ensure the acceptance criteria are satisfied.
[ ] Reassess the implementation with the IB.
[ ] Ensure no unrelated changes are included.
[ ] Ensure CI checks pass.
[ ] Check Storybook where applicable.
[ ] Ensure there is a QA Brief.
[ ] Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

[ ] Ensure the PR has the correct target branch.
[ ] Double-check that the PR is okay to be merged.
[ ] Ensure the corresponding issue has a ZenHub release assigned.
[ ] Add a changelog message to the issue.

github-actions[bot] commented 6 days ago

Build files for 79cd1ad0089326882a8dc08a75efa296d1943582 are ready:

Download development build
Download production build

10upsimon commented 6 days ago

Adding an update following internal sync and comms with @zutigrm:

The logic needed to be tweaked as the current user input options are saved to the user input settings store, they're just not persisted. This affects the modal logic (specifically due to how we retrieve the user input values) as the old vs new would always be the same in this case.

The solution was to introduce a temporary form and set the old/current site purpose. This value is in turn used in the modal to get the current values against the existing purpose slug stored in the temporary form store. The temporary form is reset on modal save so the logic can be repeated for future changes.

github-actions[bot] commented 6 days ago

Size Change: +3.4 kB (+0.18%)

Total Size: 1.87 MB

Filename	Size	Change
`./dist/assets/js/42-********************.js`	3.12 kB	+1 B (+0.03%)
`./dist/assets/js/googlesitekit-activation-********************.js`	24 kB	-10 B (-0.04%)
`./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js`	55 kB	+12 B (+0.02%)
`./dist/assets/js/googlesitekit-adminbar-********************.js`	34.6 kB	+5 B (+0.01%)
`./dist/assets/js/googlesitekit-api-********************.js`	10.1 kB	+2 B (+0.02%)
`./dist/assets/js/googlesitekit-components-gm2-********************.js`	6.08 kB	-3 B (-0.05%)
`./dist/assets/js/googlesitekit-components-gm3-********************.js`	10.1 kB	-3 B (-0.03%)
`./dist/assets/js/googlesitekit-datastore-location-********************.js`	2.08 kB	-1 B (-0.05%)
`./dist/assets/js/googlesitekit-datastore-site-********************.js`	20.5 kB	-2 B (-0.01%)
`./dist/assets/js/googlesitekit-datastore-ui-********************.js`	10.1 kB	+2 B (+0.02%)
`./dist/assets/js/googlesitekit-datastore-user-********************.js`	27.2 kB	+1 B (0%)
`./dist/assets/js/googlesitekit-entity-dashboard-********************.js`	81.6 kB	+2 B (0%)
`./dist/assets/js/googlesitekit-main-dashboard-********************.js`	159 kB	-9 B (-0.01%)
`./dist/assets/js/googlesitekit-modules-********************.js`	22.2 kB	+2 B (+0.01%)
`./dist/assets/js/googlesitekit-modules-ads-********************.js`	33.4 kB	-3 B (-0.01%)
`./dist/assets/js/googlesitekit-modules-adsense-********************.js`	117 kB	+217 B (+0.19%)
`./dist/assets/js/googlesitekit-modules-analytics-4-********************.js`	183 kB	+237 B (+0.13%)
`./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js`	22.6 kB	+66 B (+0.29%)
`./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js`	40.9 kB	-3 B (-0.01%)
`./dist/assets/js/googlesitekit-modules-search-console-********************.js`	64.8 kB	-30 B (-0.05%)
`./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js`	24.3 kB	+139 B (+0.57%)
`./dist/assets/js/googlesitekit-modules-tagmanager-********************.js`	32.2 kB	+2 B (+0.01%)
`./dist/assets/js/googlesitekit-notifications-********************.js`	22.8 kB	-70 B (-0.31%)
`./dist/assets/js/googlesitekit-settings-********************.js`	124 kB	+2.83 kB (+2.34%)
`./dist/assets/js/googlesitekit-splash-********************.js`	69.1 kB	-34 B (-0.05%)
`./dist/assets/js/googlesitekit-user-input-********************.js`	43.6 kB	+3 B (+0.01%)
`./dist/assets/js/googlesitekit-vendor-********************.js`	322 kB	+16 B (0%)
`./dist/assets/js/googlesitekit-widgets-********************.js`	94.9 kB	+21 B (+0.02%)
`./dist/assets/js/googlesitekit-wp-dashboard-********************.js`	62.6 kB	+4 B (+0.01%)
`./dist/assets/js/runtime-********************.js`	1.4 kB	+3 B (+0.21%)

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `./dist/assets/css/googlesitekit-admin-css-********************.min.css` | 59.9 kB | | `./dist/assets/css/googlesitekit-adminbar-css-********************.min.css` | 11.8 kB | | `./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css` | 846 B | | `./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css` | 8.2 kB | | `./dist/assets/js/32-********************.js` | 2.76 kB | | `./dist/assets/js/33-********************.js` | 2.25 kB | | `./dist/assets/js/34-********************.js` | 3.64 kB | | `./dist/assets/js/35-********************.js` | 935 B | | `./dist/assets/js/36-********************.js` | 893 B | | `./dist/assets/js/37-********************.js` | 1.61 kB | | `./dist/assets/js/38-********************.js` | 1.57 kB | | `./dist/assets/js/39-********************.js` | 1.61 kB | | `./dist/assets/js/40-********************.js` | 1.59 kB | | `./dist/assets/js/41-********************.js` | 1.83 kB | | `./dist/assets/js/analytics-advanced-tracking-********************.js` | 901 B | | `./dist/assets/js/googlesitekit-consent-mode-********************.js` | 25.6 kB | | `./dist/assets/js/googlesitekit-data-********************.js` | 2.37 kB | | `./dist/assets/js/googlesitekit-datastore-forms-********************.js` | 8.96 kB | | `./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js` | 646 B | | `./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js` | 624 B | | `./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js` | 630 B | | `./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js` | 712 B | | `./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js` | 675 B | | `./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js` | 634 B | | `./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js` | 657 B | | `./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js` | 633 B | | `./dist/assets/js/googlesitekit-i18n-********************.js` | 3.93 kB | | `./dist/assets/js/googlesitekit-polyfills-********************.js` | 377 B |

_{compressed-size-action}

google / site-kit-wp