Remove old Key Metrics Admin Setting Content And Make New Callout Persistent

[zutigrm]

Feature Description

Currently ACRSubtleNotification (might be renamed until it lands in execution, see #9633 ) callout is shown in the settings, and Maybe later CTA is dismissing it, showing old content instead:

This should be removed, and only callout should be displayed persistently with Maybe later CTA removed.

https://www.figma.com/design/S2CNc1toIzC7UrGMgs79S6/Conversions?node-id=1773-23216&node-type=frame&t=d6IqmuJCF2D15nqu-0

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Current ACR callout banner in admin settings should not have Maybe later CTA and should not be dismissible
• It should surface only when conversionReporting feature flag is enabled
  • Old content should be kept in the meantime until feature flag is removed, afterwards, it can be removed

Implementation Brief

• [ ] Update the logic of the ACRSubtleNotification component (likely renamed ConversionReportingSettingsSubtleNotification at the time of execution as per #9633):
  • [ ] Remove the "Maybe later" CTA altogether by removing the dismissCTA prop from the SubtleNotification component that is part of the main component return statement.
  • [ ] Remove all associate dismissal callbacks and dispatches previously associate with the now removed dismissCTA prop.

Test Coverage

• Update the test suite at assets/js/components/KeyMetrics/ACRSubtleNotification.test.js (likely renamed to ConversionReportingSettingsSubtleNotification.test.js the time of execution as per #9633):
  • Remove the should render "Maybe later" CTA test scenario.
  • Remove the does not render when dismissed test scenario, as the banner can no longer be dismissed.
  • Confirm that the test suite still passes.

QA Brief

• Setup Site Kit with Analytics module and conversionReporting feature flag
• Go to Settings > Admin Settings
• Under Key Metrics verify that callout banner do not have Maybe later CTA

Changelog entry

• Do not show "Maybe later" in Key Metrics Admin Settings callout banner.

[10upsimon]

@zutigrm AC ✅ Moving to IB and will pick up myself soon.

[zutigrm]

Thanks @10upsimon IB ✅

[mohitwp]

QA Update ✅

• Tested on dev environment.
• Verified that callout banner do not have Maybe later CTA.

 https://github.com/user-attachments/assets/def8552d-6933-493b-9590-6c5e994e300a