google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 292 forks source link

Toggle display group as 'On' when changing analytics and enabling groups #9700

Open kelvinballoo opened 1 week ago

kelvinballoo commented 1 week ago

Bug Description

This arose when doing Audience segmentation E2E test. Currently, if under an admin toggles off the display visitor groups and changes analytics property. If they enable the groups under the new analytics property, the toggle remains off but they still get a notification that visitor groups have been added to the dashboard. If we click on 'Show me' CTA, nothing shows up then.

Bottom line is when we 'enable groups' in the backend settings, we should toggle the display to 'ON'. Else, there will be a scenario where the messaging doesn't align with the dashboard.

I've detailed everything in the attached video.

Steps to reproduce

  1. Set up AS tiles.
  2. Go to SK settings and toggle the 'Display visitor groups in dashboard' to off.
  3. Change to another analytics property.
  4. Go to SK settings and click on 'Enable groups'.

You will see a message that Visitor groups have been added to the dashboard. However, when you go to the dashboard, nothing shows up.

Screenshots

https://github.com/user-attachments/assets/6f945fa9-06b3-4666-a6e7-cf5921543ec1

Additional Context


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry