search

google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 292 forks source link

Adjust styling of the SiWG button on login pages #9722

Open wpdarren opened 5 days ago

wpdarren commented 5 days ago

Bug Description

From the SiWG bug bash. Asana ticket can be found here.

The SiWG button doesn't stretch across the input fields, which is different than the figma designs.

It does initially load in this way but then resizes.

@tofumatt also noted:

Stretching the button is something I noticed in WooCommerce but might actually be against the button styling guidelines. It might be better to centre this and shrink the WooCommerce one, but in any case this does need to be tweaked 👍

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

jimmymadon commented 1 day ago

@wpdarren I can't reproduce the unaligned version of the button on either the WP Login Page or the WooCommerce login page. I even tried throttling the network speed to 3G and it still appears fine to me.

@tofumatt If the button is already stretched by default due to the parent containers that the button falls in, should we spend time on resizing and centring this?