Hide one tap sign in because it does not currently function

wpdarren commented 5 days ago

Bug Description

From the SiWG bug bash. Asana ticket can be found here.

Due to the recent changes for the login, this functionality is not currently working as expected. Users on the frontend of the WordPress website should be prompted to sign in, but we aren’t triggering any SiWG code/JS/flows from generic pages right now.

We should hide this toggle, and description for the launch.

Slack conversation here for context

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Remove the One Tap Toggle from the SiWG settings forms.

Implementation Brief

[ ] Within assets/js/modules/sign-in-with-google/components/settings/SettingsForm.js, remove the <OneTapToggle> component and its <Cell> wrapper. Do not delete the <OneTapToggle> component and its related datastore infrastructure as this feature could be introduced back in the near future.

Test Coverage

No new tests required.

QA Brief

Changelog entry

eugene-manuilov commented 1 day ago

... Users on the frontend of the WordPress website should be prompted to sign in, but we aren’t triggering any SiWG code/JS/flows from generic pages right now.

We should hide this toggle, and description for the launch.

@wpdarren, why should we do it? Why not to trigger the appropriate script on the frontend instead? It is a simple fix as far as I understand it.

tofumatt commented 9 hours ago

This can be closed as a won't fix, as we've decided to leave the one-tap functionality in-place 👍🏻

google / site-kit-wp