The defer f.Close call is still there, so this ends up closing the file twice (which doesn't appear to cause a problem).
Let me know if you think lines 622-657 should be extracted out to a separate method (so that defer will be sufficient); I couldn't decide if that would improve readability/maintainability or not.
The
defer f.Close
call is still there, so this ends up closing the file twice (which doesn't appear to cause a problem).Let me know if you think lines 622-657 should be extracted out to a separate method (so that
defer
will be sufficient); I couldn't decide if that would improve readability/maintainability or not.