google / skylark

Skylark in Go: the Skylark configuration language, implemented in Go [MOVED to go.starlark.net]
BSD 3-Clause "New" or "Revised" License
1.19k stars 74 forks source link

Fix function comments based on best practices from Effective Go #142

Open CodeLingoTeam opened 5 years ago

CodeLingoTeam commented 5 years ago

Hi, we updated an exported function comment based on best practices from Effective Go. It’s admittedly a relatively minor fix up. Does this help you?

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

alandonovan commented 5 years ago

Thanks! Once you've signed the CLA, we can commit this change.