google / skywater-pdk-sky130-raw-data

Raw data collected about the SKY130 process technology.

https://sky130-pdk.rtfd.io

Apache License 2.0

50 stars 17 forks source link

Added new experimental data #23

Open hung-chi opened 1 year ago

hung-chi commented 1 year ago

[x] Tests pass
[x] Appropriate changes to README are included in PR

msaligane commented 1 year ago

@hung-chi Can you add the notebook you showed me last Friday?

hung-chi commented 1 year ago

@hung-chi Can you add the notebook you showed me last Friday?

You can find the notebook at https://github.com/hung-chi/skywater-pdk-sky130-raw-data/blob/develop/notebooks/electrical_characterization_sky130_epfl.ipynb

mithro commented 1 year ago

@hung-chi - Is that notebooks part of this pull request?

hung-chi commented 1 year ago

@hung-chi - Is that notebooks part of this pull request?

Yes, the notebook is included. You could find it in my forked repo at https://github.com/hung-chi/skywater-pdk-sky130-raw-data/blob/develop/notebooks/electrical_characterization_sky130_epfl.ipynb

hung-chi commented 1 year ago

@msaligane

I added the Gm/ID plot. You can find them in the updated notebook.

hung-chi commented 1 year ago

23

proppy commented 1 year ago

@hung-chi thanks for working on this!

Do you think it would it makes sense to modify the notebook so that they can be opened in https://colab.research.google.com/ ?

If you agree, maybe we can do the follow-up changes (either in this PR or separatly):

inline the utils in sky130_plot_epfl_data_general notebook (they only seem to be used here)
add a colab badge similar to the other notebooks (see https://github.com/google/skywater-pdk-sky130-raw-data/blob/main/notebooks/sky130_plot_current.ipynb)
self-clone the repo in the first cell (so that the data is accessible from the hosted notebook environment)

hung-chi commented 1 year ago

@hung-chi thanks for working on this!

Do you think it would it makes sense to modify the notebook so that they can be opened in https://colab.research.google.com/ ?

If you agree, maybe we can do the follow-up changes (either in this PR or separatly):

inline the utils in sky130_plot_epfl_data_general notebook (they only seem to be used here)

add a colab badge similar to the other notebooks (see https://github.com/google/skywater-pdk-sky130-raw-data/blob/main/notebooks/sky130_plot_current.ipynb)

self-clone the repo in the first cell (so that the data is accessible from the hosted notebook environment)

Sure, I can do that in the PR. Also fine with inlining the utils in sky130_plot_epfl_data_general notebook.

hung-chi commented 1 year ago

Hi @proppy

I have updated the notebook by including the self-clone, in-line utils, colab. The notebook will work correctly after merging.

Thanks