google / skywater-pdk

Open source process design kit for usage with SkyWater Technology Foundry's 130nm node.
https://skywater-pdk.rtfd.io
Apache License 2.0
2.99k stars 391 forks source link

Error in Stackup? #21

Closed thesourcerer8 closed 4 years ago

thesourcerer8 commented 4 years ago

In the stackup diagram: https://raw.githubusercontent.com/google/skywater-pdk/0bd4367203243e40d46a8835670db950c1f339a5/docs/_static/metal_stack.svg I see 2 different vias called "via2" and "via3", is that a copy&paste error?

RTimothyEdwards commented 4 years ago

@thesourcerer8 : Yes, that's an error, thanks for pointing it out. It comes from the fact that the MiM caps were added to the current process from an earlier process variant that had a different metal stack, so it was not obvious which metal layers the MiM caps are located above. I moved them up one metal layer and didn't change the via names.

RTimothyEdwards commented 4 years ago

@mithro : I have a corrected SVG file; does it go in this repo, or is it originating from elsewhere?

RTimothyEdwards commented 4 years ago

@mithro : I can't see the stackup file in the repo. Where is it? Also, can I get authority to push to the repo?

mithro commented 4 years ago

@RTimothyEdwards You'll need to send pull requests.

mithro commented 4 years ago

FYI -- The SVG hasn't been merged yet, it is in the pull request at https://github.com/google/skywater-pdk/pull/19

RTimothyEdwards commented 4 years ago

@mithro : I suppose I must wait for you to merge the pull request before I can then update the drawing and make a new pull request?

mithro commented 4 years ago

The fixed metal_stack.svg file from @RTimothyEdwards is now in the pull request #19