Open Manarabdelaty opened 3 years ago
The endif directive should be followed by the macro name commented out. Correct behavior is like
endif
endif // SKY130_FD_SC_HD__LPFLOW_BLEEDER_FUNCTIONAL_PP_V
where the macro the name is commented out
https://cs.opensource.google/skywater-pdk/sky130_fd_sc_hd/+/master:cells/lpflow_bleeder/sky130_fd_sc_hd__lpflow_bleeder.functional.pp.v;l=44
The functional model of the sky130_fd_sc_hd__lpflow_bleeder cell has invalid verilog syntax at
sky130_fd_sc_hd__lpflow_bleeder
endif SKY130_FD_SC_HD__LPFLOW_BLEEDER_FUNCTIONAL_V
because the macro name isn't commented out.
https://cs.opensource.google/skywater-pdk/sky130_fd_sc_hd/+/master:cells/lpflow_bleeder/sky130_fd_sc_hd__lpflow_bleeder.functional.v
Compiling the verilog file using iverilog will flag a syntax error.
1.iverilog sky130_fd_sc_hd__lpflow_bleeder.functional.v
iverilog sky130_fd_sc_hd__lpflow_bleeder.functional.v
Corrected in pull request #4 to https://github.com/efabless/skywater-pdk-libs-sky130_fd_sc_hd fork, which automatically updates the upstream repos.
Expected Behavior
The
endif
directive should be followed by the macro name commented out. Correct behavior is likeendif // SKY130_FD_SC_HD__LPFLOW_BLEEDER_FUNCTIONAL_PP_V
where the macro the name is commented out
https://cs.opensource.google/skywater-pdk/sky130_fd_sc_hd/+/master:cells/lpflow_bleeder/sky130_fd_sc_hd__lpflow_bleeder.functional.pp.v;l=44
Actual Behavior
The functional model of the
sky130_fd_sc_hd__lpflow_bleeder
cell has invalid verilog syntax atendif SKY130_FD_SC_HD__LPFLOW_BLEEDER_FUNCTIONAL_V
because the macro name isn't commented out.
https://cs.opensource.google/skywater-pdk/sky130_fd_sc_hd/+/master:cells/lpflow_bleeder/sky130_fd_sc_hd__lpflow_bleeder.functional.v
Steps to Reproduce the Problem
Compiling the verilog file using iverilog will flag a syntax error.
1.
iverilog sky130_fd_sc_hd__lpflow_bleeder.functional.v
Specifications