google / skywater-pdk

Open source process design kit for usage with SkyWater Technology Foundry's 130nm node.
https://skywater-pdk.rtfd.io
Apache License 2.0
3k stars 391 forks source link

Faulty .include in file "library/skywater-pdk-libs-sky130_fd_pr/blob/main/cells/nfet_05v0_nvt/sky130_fd_pr__nfet_05v0_nvt.pm3.spice #439

Open PW-HsH opened 1 month ago

PW-HsH commented 1 month ago

Dear Sir or Madam,

I am unsure if this is the appropriate channel for this query, but I believe the "include" directive in line 16 of this file: https://github.com/google/skywater-pdk-libs-sky130_fd_pr/blob/main/cells/nfet_05v0_nvt/sky130_fd_pr__nfet_05v0_nvt.pm3.spice may require attention.

The line is currently: include "sky130_fd_pr__esd_nfet_05v0_nvt.pm3"

and I think it needs to be changed to: .include "../esd_nfet_05v0_nvt/sky130_fd_pr__esd_nfet_05v0_nvt.pm3.spice"

The "include" is missing the leading "." and the file to be included resides in a different directory. Also, the ".spice" ending is missing.

Best regards,

Pascal

RTimothyEdwards commented 1 month ago

@PW-HsH : Use the heavily-patched fork at https://github.com/efabless/skywater-pdk-libs-sky130_fd_pr, not the Google repository, which has been archived.