search

google / slo-generator

SLO Generator computes SLIs, SLOs, Error Budgets and Burn Rates from supported backends, then exports an SLO report to supported targets.
Apache License 2.0
488 stars 78 forks source link

Push container image to ghcr.io #159

Closed ocervell closed 1 year ago

ocervell commented 3 years ago

Currently we deploy to GCR only

lvaylet commented 2 years ago

What is the objective/value here? Being able to pull images from GitHub's own registry in GitHub Actions workflows?

ocervell commented 2 years ago

Yes, for instance, or have a public image hosted on ghcr.io in case GCR is for some reason unavailable / down (since it's on a test org project ..)

lvaylet commented 1 year ago

Sounds good. I think the best option is to add this feature to cloudbuild.yaml so every workflow (build and deploy mainly) automatically inherits it when they run make cloudbuild. We could use GitHub Actions to stay within GitHub but that would make the code less maintainable in my opinion. Let's build once in a single place, and push to many registries as needed.

lvaylet commented 1 year ago

The Container Registry documentation is here, with instructions on how to authenticate and how to push. From Cloud Build, we can probably authenticate by forwarding the workflow's ${{ secrets.GITHUB_TOKEN }} (compared to a Personal Access Token) as the image will be pushed to the same repository as the workflow itself.

lvaylet commented 1 year ago

Here is a sample GitHub Actions workflow responsible for building and publishing a package to the GitHub Container Registry: https://docs.github.com/en/packages/managing-github-packages-using-github-actions-workflows/publishing-and-installing-a-package-with-github-actions#publishing-a-package-using-an-action

lvaylet commented 1 year ago

Let's use the sample GitHub Actions workflow above as we are in a bit of a hurry. I had to remove public access to the GCS bucket hosting the Docker images of the Container Registry after a huge spike in egress costs in October. Some users like Adeo have their own image in a private registry, so they are not impacted. I granted the right permissions to other users like Decathlon, so they are not impacted either. This being said, other users (new and existing) might be impacted so we need an alternative to gcr.io. I successfully tested the workflow above in another repository. I just had to adapt it to semantic versioning (semver).