search

google / slo-generator

SLO Generator computes SLIs, SLOs, Error Budgets and Burn Rates from supported backends, then exports an SLO report to supported targets.
Apache License 2.0
489 stars 78 forks source link

Shorter window can not have more bad events than a longer window #313

Closed dirtyren closed 1 year ago

dirtyren commented 1 year ago

Due to promtheus increase errors, some time a shorter window will have more bad events than a longer window, which should no happen and will generate a invalid SLI. When this happens, we discard the calculation for the shorter window. The patch also reuse the backend data if window is the same, when we have the same window doing calculations for different burning rates

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.