google / slo-generator

SLO Generator computes SLIs, SLOs, Error Budgets and Burn Rates from supported backends, then exports an SLO report to supported targets.
Apache License 2.0
489 stars 78 forks source link

🐛 [BUG] - Unit tests are failing with all versions of Python #421

Closed lvaylet closed 10 months ago

lvaylet commented 10 months ago

SLO Generator Version

all

Python Version

all

What happened?

https://github.com/google/slo-generator/actions/runs/7580364135/job/20646052719

What did you expect?

Unit tests should still pass. The code is still the same. No recent changes.

Screenshots

No response

Relevant log output

No response

Code of Conduct

lvaylet commented 10 months ago

Not sure what is going on. The same checks used to complete successfully just two weeks ago, also with Python 3.9.18, pytest-7.4.4, pluggy-1.3.0 and cov-4.1.0.

Next step: compare the versions of the packages installed by make install and look for differences.

lvaylet commented 10 months ago

Unit tests complete successfully when safety is pinned to version 2.3.5, while 3.0 and above cause the unit tests to fail.