Included additional metrics to be exposed. Only 6/7 metrics are being exposed if I am using the promethues as a backend and the pushgateway as an exporter.

google / slo-generator

SLO Generator computes SLIs, SLOs, Error Budgets and Burn Rates from supported backends, then exports an SLO report to supported targets.

Apache License 2.0

489 stars 78 forks source link

Included additional metrics to be exposed. Only 6/7 metrics are being exposed if I am using the promethues as a backend and the pushgateway as an exporter. #493

Open ppothepa24 opened 4 months ago

ppothepa24 commented 4 months ago

I have made changes to the files in base.py and report.py to ensure that additional metrics namely (error_budget_target, error_budget_measurement, error_budget_burn_rate, error_budget_remaining_minutes, error_budget_minutes etc) be exposed. But i am not sure if these changes are actually being compiled and executed as the changes in the source code arent reflecting in the output.

google-cla[bot] commented 4 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

lvaylet commented 4 months ago

Hi @ppothepa24, I will take a look later this week. I have a lot on my plate right now, and find myself unable to spend as much time as I'd like on the SLO Generator.

lvaylet commented 4 months ago

I replied in https://github.com/google/slo-generator/discussions/490#discussioncomment-10032004.