search

google / smali

Other
201 stars 35 forks source link

Add back Java 8 support #34

Closed ThexXTURBOXx closed 7 months ago

ThexXTURBOXx commented 7 months ago

I don't see a problem still supporting Java 8 since it is still widely used, so this PR adds back support for it (examples of popular projects still supporting Java 8, but also needing smali are BCV, dex2jar and apktool). Also, I noticed that a few tests rely on LF line endings, hence they fail on Windows (CRLF line endings). JUnit 5 offers assertLinesMatch which is exactly what is needed here, but Smali still relies on JUnit 4, sadly. So, it's not available.

sgjesse commented 7 months ago

Thank you for the PR. I have moved our CI back to JDK-8 as well, so the Maven binaries will be built with JDK-8.

However, we will still keep the option of switching to JDK-11 open, if at some point there is a compelling reason to do so.

ThexXTURBOXx commented 7 months ago

Thank you very much for merging this! This will probably help a lot of users of above applications. I will stay tuned for updates!