search

google / smali

Other
213 stars 35 forks source link

Introduce caching in the writeDebugItem process to enable the reuse of debugInfo #39

Closed magicalmcgrady closed 7 months ago

magicalmcgrady commented 8 months ago

Background: R8 has adopted a debugInfo line number optimization strategy that allows for the reuse of debugInfo. The current implementation of writeDebugItem redundantly writes the same debugInfo items, resulting in redundancy.

Optimization: Introduce caching in the writeDebugItem process to enable the reuse of debugInfo.

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

magicalmcgrady commented 8 months ago

hi @sgjesse @melcz I've submitted a PR here and I noticed that I don't have the permissions to add reviewers. Could you please take a look at this PR when you have a chance? Your feedback would be greatly appreciated. Thank you!

magicalmcgrady commented 7 months ago

@zerny I've made the requested changes to the pull request. Could you please review it