Open lacalasolutions opened 4 months ago
Thank you for the report.
Can you please explain what you mean by tried on two different phones to install smali? Looks as if you are having an issue building smali, and usually that is not something you will do on a phone.
This commit added support for generating the SBOM (by running ./gradlew dexlib2:spdxSbomRelease
), and the org.spdx.sbom
plugin has a dependency on org.spdx:spdx-jackson-store:1.1.9.1
(see https://github.com/spdx/spdx-gradle-plugin/blob/main/build.gradle.kts).
When I run:
$JAVA_HOME/bin/java --version
./gradlew test
I get openjdk 11 2018-09-25
(the one I use) and testing succeeds.
You could try building from commit 5f8b0491e8d925396873292a98c1d3bfd3e2c44a
instead.
Just checked a second time. This is an issue with the dependencies coming from jcenter, running
./gradlew --refresh-dependencies test
fails getting dependencies from jcenter, which has been turned down.
Building from commit 5f8b0491e8d925396873292a98c1d3bfd3e2c44a
works.
Thank you for your response. I will build from the other commitc
On Wed, Jul 3, 2024, 3:33 AM Søren Gjesse @.***> wrote:
Just checked a second time. This is an issue with the dependencies coming from jcenter, running
./gradlew --refresh-dependencies test
fails getting dependencies from jcenter, which has been turned down https://developer.android.com/build/jcenter-migration.
Building from commit 5f8b0491e8d925396873292a98c1d3bfd3e2c44a https://github.com/google/smali/commit/5f8b0491e8d925396873292a98c1d3bfd3e2c44a works.
— Reply to this email directly, view it on GitHub https://github.com/google/smali/issues/62#issuecomment-2205296966, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5G7FO6DQKIQW67Y4DV2FW3ZKOSM7AVCNFSM6AAAAABKIUWBNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBVGI4TMOJWGY . You are receiving this because you authored the thread.Message ID: @.***>
The build worked on my Android phone in 33s. Thanks so much!!
On Wed, Jul 3, 2024, 8:59 AM Eric Arillo @.***> wrote:
Thank you for your response. I will build from the other commitc
On Wed, Jul 3, 2024, 3:33 AM Søren Gjesse @.***> wrote:
Just checked a second time. This is an issue with the dependencies coming from jcenter, running
./gradlew --refresh-dependencies test
fails getting dependencies from jcenter, which has been turned down https://developer.android.com/build/jcenter-migration.
Building from commit 5f8b0491e8d925396873292a98c1d3bfd3e2c44a https://github.com/google/smali/commit/5f8b0491e8d925396873292a98c1d3bfd3e2c44a works.
— Reply to this email directly, view it on GitHub https://github.com/google/smali/issues/62#issuecomment-2205296966, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5G7FO6DQKIQW67Y4DV2FW3ZKOSM7AVCNFSM6AAAAABKIUWBNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBVGI4TMOJWGY . You are receiving this because you authored the thread.Message ID: @.***>
Good to hear that you succeeded in building. I will keep this open, as the transitive use of jcenter
for building is not good.
Is this something a newb could deal with. I'd like to make a new repo with updated info on github if its helpful.
On Thu, Jul 4, 2024, 6:12 AM Søren Gjesse @.***> wrote:
Good to hear that you succeeded in building. I will keep this open, as the transitive use of jcenter for building is not good.
— Reply to this email directly, view it on GitHub https://github.com/google/smali/issues/62#issuecomment-2208612303, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5G7FO3JVNTB67HQDLDFKN3ZKUNX3AVCNFSM6AAAAABKIUWBNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBYGYYTEMZQGM . You are receiving this because you authored the thread.Message ID: @.***>
Just tried this again today, and could not reproduce the issue with ./gradlew --refresh-dependencies test
any more. Could you try with main
once again?
I was also unable to build/test on main, now I am able to run assemble but test fails with an InaccessibleObjectException
and many NoClassDefFoundException
com.android.tools.smali.dexlib2.DexEntryFinderTest > testNormalStuff FAILED
java.lang.ExceptionInInitializerError at DexEntryFinderTest.java:58
Caused by: java.lang.reflect.InaccessibleObjectException at DexEntryFinderTest.java:58
com.android.tools.smali.dexlib2.DexEntryFinderTest > testMatchingSuffix FAILED
java.lang.NoClassDefFoundError at DexEntryFinderTest.java:131
Caused by: java.lang.ExceptionInInitializerError at DexEntryFinderTest.java:58
Looks as if the test failures are related to a very old version of Mockito Core, update in https://github.com/google/smali/pull/67.
Hello, I've tried on two different phones to install smali. I checked recent issues and faqs. I don't see anything similar. I get the following error > Could not resolve org.spdx:spdx-jackson-store:1.1.9.1.
I also added google to the list of repos in the build files. If anyone could shed some light I'd be grateful.