google / smali

Other
212 stars 35 forks source link

Rewriter bug fixes #72

Closed melcz closed 2 months ago

melcz commented 2 months ago

There have been some reports of errors when rewriting dex files. I believe partially this is because of the refactoring of iterables/iterators from guava into self contained implementations (chained and transformed). With this change, the behavior between iterable and iterator should be fixed and consistent with what guava has.

This issue points that testing for the rewriting libraries is insufficient, as tests were passing before and are passing after this change. However, given that reproducibility details were insufficient in the reports, I myself was never able to minimally reproduce the issues the users were reporting.