search

google / souper

A superoptimizer for LLVM IR
Apache License 2.0
2.11k stars 167 forks source link

Fixing different Clang-Tidy warnings #343

Open zamazan4ik opened 5 years ago

zamazan4ik commented 5 years ago

Hello.

I ran clang-tidy on souper project and found a lot of different warnings. Are you welcome any PRs with fixing warnings?

regehr commented 5 years ago

Hi! I think that we do not want a lot of smallish changes right now, we have a lot of branches in flight and this would make merges challenging. Of course, if there are significant bugs to fix, that is a different matter and we'd love to have patches.

zamazan4ik commented 5 years ago

Ok. Understood. I didn't find yet any critical changes by clang-tidy or other static analyzers. Maybe in the future will be fine to connect Coverity to the repo. Also I find in Souper some parsers, which would be fine to test with fuzzers. Of course, if I will find anything important - I will send a PR.

P.S. Btw, @regehr is your email from the page still valid? I can't contact with you during weeks.