google / spatial-media

Specifications and tools for 360º video and spatial audio.
Other
1.86k stars 429 forks source link

fix misleading FullBox parameters #144

Closed fcartegnie closed 7 years ago

fcartegnie commented 7 years ago

FullBox as defined by ISO14496-12 has 8+24bits for versioning and flags. Passing both 32bits integers for those params is misleading and will anyway be truncated.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


fcartegnie commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

dcower commented 7 years ago

Thanks, Francois! LGTM. Passing this on to Aaron to double check. :)