google / spatial-media

Specifications and tools for 360º video and spatial audio.
Other
1.86k stars 429 forks source link

Works with Python 3.x #145

Closed griffin2000 closed 7 years ago

griffin2000 commented 7 years ago

I have upgraded the code to work with Python 3.x. I have not tested exhaustively but verified (with Python 3.5.1) that I can inject video metadata and YouTube will understand it (and read it back with the spatialaudio app). I've not tested the audio side

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


griffin2000 commented 7 years ago

I get the following error. I've tried a few times. Any idea what the issue could be?

[cid:b2e04510-f120-42d6-8d7d-b24c05ea92a7]


From: googlebot notifications@github.com Sent: 06 December 2016 05:23 To: google/spatial-media Cc: Gareth Morgan; Author Subject: Re: [google/spatial-media] Works with Python 3.x (#145)

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

?? Please visit https://cla.developers.google.com/ to sign.

About - Google CLAhttps://cla.developers.google.com/ cla.developers.google.com When you sign a Contributor License Agreement (CLA), you give Google the legal permission to use and distribute your contribution. You do not surrender ownership of ...

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/google/spatial-media/pull/145#issuecomment-265063815, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA9lQhxBvnoKecN7NfBhYwPakFQkFqg9ks5rFPFigaJpZM4LFCVP.

griffin2000 commented 7 years ago

I can't submiy my CLA. I've been trying for a while with differnent browsers and email address. Same result "A server error occurred, please try your request again": image

griffin2000 commented 7 years ago

Actually CLA finally went through.

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

griffin2000 commented 7 years ago

It just when through (Dec 06, 2016 13:18 PST). It uses my github ID (griffin2000) and the associated github email (my hotmail) image

griffin2000 commented 7 years ago

Just realized there was a bug in my 3.x byte-string conversion code. Resubmitting with fix.