Open kodawah opened 7 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
Any update on this?
¯\_(ツ)_/¯
@kodabb I think the bot is waiting for you to sign the Contributor License Agreement and then reply I signed it!
:)
@Boscop there is already code from me in master https://github.com/google/spatial-media/commit/f6bf328cb8bc888e6d95f4c60a97891cd5541cce
half the spec was written with a collaboration of facebook, youtube and vimeo, I don't think there is a need to be overly formal here
@kodabb But the bot doesn't know it. Just write I signed it!
and see what the bot responds, otherwise this will be stuck forever :/
@Boscop unfortunately i don't have time to resolve the conflicts, and my branch serves my usecase pretty well. Plus CLAs are stupid.
You have my permission to update it and go in the process of having it merged if you so desire
This PR removes any v1 reference and adds support for v2 spherical videos. Not my best python code, but it should get the job done. Let me know what you think.