google / sqlcommenter

Apache License 2.0
604 stars 81 forks source link

Clarification on the specification #242

Open EricStG opened 1 year ago

EricStG commented 1 year ago

Looking at the Key Value Format section, I'm a little confused

First, the second example seems to be off, the value serialize value + final don't match the initial value

KEY VALUE PAIR SERIALIZED_KEY SERIALIZED_VALUE FINAL
name='DROP TABLE FOO' route '%2Fpolls%201000' route='%2Fpolls%201000'

Then in the 3rd example:

KEY VALUE PAIR SERIALIZED_KEY SERIALIZED_VALUE FINAL
name''="DROP TABLE USERS'" name='' DROP%20TABLE%20USERS' name=''=‘DROP%20TABLE%20USERS'’

Shouldn't the name'' key has its quote escaped to name\'\'? And where does the second equal (=) in the Final form comes from?

Thank you.