google / starlark-go

Starlark in Go: the Starlark configuration language, implemented in Go
BSD 3-Clause "New" or "Revised" License
2.34k stars 212 forks source link

starlark: use Unhashable errors to indicate hash failures #165

Open josharian opened 5 years ago

josharian commented 5 years ago

Fixes #113. See that issue for discussion.

josharian commented 5 years ago

I don't think a decision has been reached, but the implementation of that feature would require significant changes to the existing Hash method

Ack. Shall we put this PR on hold until a decision has been reached?