google / starlark-go

Starlark in Go: the Starlark configuration language, implemented in Go
BSD 3-Clause "New" or "Revised" License
2.3k stars 209 forks source link

type Int struct{ impl intImpl } should type Int struct{ in… #282

Closed anyktx closed 4 years ago

anyktx commented 4 years ago

type Int struct{ impl intImpl } raise bug at starlark/int_generic.go:22. should be type Int struct{ intImpl }

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

alandonovan commented 4 years ago

Update: I rolled the fix into https://github.com/google/starlark-go/pull/283, which fixes the tests for 32-bit platforms (e.g. 386), so this change is no longer needed.

Thanks again for pointing it out.