compile error (int overflow) in eval_test.go on 32-bit GOARCH

google / starlark-go

Starlark in Go: the Starlark configuration language, implemented in Go

BSD 3-Clause "New" or "Revised" License

2.3k stars 209 forks source link

compile error (int overflow) in eval_test.go on 32-bit GOARCH #335

Closed eclipseo closed 3 years ago

eclipseo commented 3 years ago

Testing Starlark fails due to Int overflow:

testing: go.starlark.net
go.starlark.net/internal/compile
PASS
ok      go.starlark.net/internal/compile    0.006s
go.starlark.net/starlark
# go.starlark.net/starlark_test [go.starlark.net/starlark.test]
./eval_test.go:724:23: constant 1099511627776 overflows int
./eval_test.go:725:24: constant -1099511627776 overflows int
FAIL    go.starlark.net/starlark [build failed]

alandonovan commented 3 years ago

Fixed by 8756d3ec17702f93b2d5e50e9ea6762f30bec167