search

google / starlark-go

Starlark in Go: the Starlark configuration language, implemented in Go
BSD 3-Clause "New" or "Revised" License
2.32k stars 212 forks source link

rename math.abs to math.fabs (fixes #362) and introduce `Universe["abs"]` #363

Closed fenollp closed 3 years ago

fenollp commented 3 years ago

I get two failures that I could not figure out myself. Ideas?

--- FAIL: TestExecFile (0.14s)
    starlarktest.go:117: Traceback (most recent call last):
          /home/pete/wefwefwef/go/src/go.starlark.net/starlark/testdata/builtins.star:27:10: in <toplevel>
          /home/pete/wefwefwef/go/src/go.starlark.net/starlarktest/assert.star:14:14: in _eq
        Error: 1 != 2
    starlarktest.go:117: Traceback (most recent call last):
          /home/pete/wefwefwef/go/src/go.starlark.net/starlark/testdata/builtins.star:37:11: in <toplevel>
          /home/pete/wefwefwef/go/src/go.starlark.net/starlark/testdata/builtins.star:35:11: in abs_bigint
          /home/pete/wefwefwef/go/src/go.starlark.net/starlarktest/assert.star:14:14: in _eq
        Error: 264140488580 != -264140488581
FAIL
fenollp commented 3 years ago

I fixed said issues. Can you review this @adonovan please?

adonovan commented 3 years ago

Thanks for the contribution, and sorry I didn't notice it until now.

fenollp commented 3 years ago

There you go. Thanks for the review and no worries.