search

google / starlark-go

Starlark in Go: the Starlark configuration language, implemented in Go
BSD 3-Clause "New" or "Revised" License
2.31k stars 210 forks source link

lib/proto: add support for instantiating proto map fields #491

Closed tazjin closed 1 year ago

tazjin commented 1 year ago

With this change, it becomes possible to instantiate map<k,v> type fields in Protobuf messages from Starlark.

Maps can be constructed from any Starlark type that implements starlark.IterableMapping.

Protobuf messages can have most types as keys/values, so the type conformity is checked individually for each key/value pair (as the Starlark side of things is dynamically typed).

This has been tested against fairly complex proto messages containing maps.

Map operations apart from construction are not supported in this CL.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

tazjin commented 1 year ago

Fixed author email address for CLA.

tazjin commented 1 year ago

Fixed those, thanks.