google / starlark-go

Starlark in Go: the Starlark configuration language, implemented in Go
BSD 3-Clause "New" or "Revised" License
2.26k stars 204 forks source link

draft: extended comparison functions return Value type #542

Closed hungtcs closed 2 months ago

hungtcs commented 2 months ago

Ref #541 Note: draft

Temporarily added a new interface to let the Compare method return the Value type, and use the Truth method of Value as the basis for the bool's judgment.

The purpose of this is to allow more flexibility in the types that can be implemented through Go code extensions.

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.