google / startup-os

Working examples of Google's Open Source stack and deployment to the cloud.
Apache License 2.0
671 stars 101 forks source link

gRPC microservices example can not run: GitRepoFactory.java is missing in repository. #600

Open Instein98 opened 2 years ago

Instein98 commented 2 years ago

Hi, I am trying to run the gRPC microservices example mentioned in the README.md, but I found that LocalServer.java can not run because it tries to import a nonexistent class com.google.startupos.common.repo.GitRepoFactory.

Could you please help me solve this issue? Thanks!!

oferb commented 2 years ago

Hi, This repo is not supported at this point.

What I can say is, GitRepo uses AutoFactory which should create GitRepoFactory, but doesn't, and that's the issue here I think.

https://github.com/google/startup-os/blob/master/common/repo/GitRepo.java#L34

You may be able to get away with creating the GitRepo directly in LocalServer, using the constructor, by passing fileUtils which LocalServer already has access to, and the path which you pass to .create().

https://github.com/google/startup-os/blob/master/common/repo/GitRepo.java#L48 https://github.com/google/startup-os/blob/master/tools/reviewer/local_server/LocalServer.java#L97

Sorry I can't help more.