google / stenographer

Stenographer is a packet capture solution which aims to quickly spool all packets to disk, then provide simple, fast access to subsets of those packets. Discussion/announcements at stenographer@googlegroups.com
Apache License 2.0
1.79k stars 238 forks source link

Hyperlink to save time #186

Closed nrshrivatsan closed 5 years ago

nrshrivatsan commented 6 years ago

INSTALL.md & DESIGN.md hyperlinking

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
gconnell commented 5 years ago

Happy to merge this if/when CLA is signed :)

hosom commented 5 years ago

CLA was signed on the last contribution, bot says it’s up to date.

Can sign again if needed :)

On Tue, Jan 8, 2019 at 12:31 PM Graeme Connell notifications@github.com wrote:

Happy to merge this if/when CLA is signed :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/stenographer/pull/186#issuecomment-452384046, or mute the thread https://github.com/notifications/unsubscribe-auth/AEyO7N8kcylTv7EE7ZkAc61PPg9RnHmNks5vBNXagaJpZM4TetTk .

gconnell commented 5 years ago

Hmm, I still see:

@googlebot cla/google — Need a CLA for the pull request sender

It could be because this appears to be from a strange source email address:

https://github.com/google/stenographer/commit/e2dfea4e1179b1bc03a978551628f7e1d08b9674.patch says the patch was created by "nrshrivatsan@users.noreply.github.com". That email must match the email that accepted the CLA.

Compare that to, for example, https://github.com/google/stenographer/commit/de56372e95756ead84acea17d237c73dd51fe41c.patch where the email address is more sane.

googlebot commented 5 years ago

CLAs look good, thanks!

gconnell commented 5 years ago

Oh, sure, now Googlebot thinks it's okay :P

Thanks!