google / step49-2020

3 stars 2 forks source link

Implement max depth feature for graph with user selection #19

Closed haoyxc closed 4 years ago

haoyxc commented 4 years ago

Allow users to select the max depth they want to see and implement function to display graph on the page such that every node is at most the max depth from a root.

Included test cases for finding the roots and the maxDepth function in Data Servlet.

If the requested depth is less than the max depth of the graph: image

If requested depth is the max depth of the graph, whole graph is given: image

If the requested depth is greater than the maximum (same graph as above): image

Things to consider still: not reading the file on every request (will do in another PR) For user input testing, I thought it might be smart to include them in one PR so there aren't more merge issues than necessary, and I think Ishani has started JS testing on the "click" branch!

googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

haoyxc commented 4 years ago

dropdown changed to an input! can change min/max/default at any point wasn't sure what was best haha image

haoyxc commented 4 years ago

@EatingW do you think you could approve it again? I removed gNodeB and gNodeC and I think it dismissed your review :/