google / streamy-dart

Apache License 2.0
60 stars 23 forks source link

SimpleRequestHandler should close its stream on completion #270

Open gsadams opened 9 years ago

gsadams commented 9 years ago

The SimpleRequestHandler (in lib/impl.dart) doesn't close its stream after it receives a server response. Otherwise, the stream (and any listeners subscribed to it) will hang around indefinitely.

An example of the correct behavior is in ProxyClient (lib/runtime/proxy.dart). Notice that it calls c.close() both on success and error.