search

google / styleguide

Style guides for Google-originated open-source projects
https://google.github.io/styleguide/
Apache License 2.0
37.53k stars 13.3k forks source link

Error print from https://github.com/cpplint/cpplint fixed #750

Open haobo724 opened 1 year ago

haobo724 commented 1 year ago

something wrong with function sys.stderr.write() in file cpplint.py when I use cpplint.py from git@github.com:google/styleguide.git the console always shows an Error msg: TypeError('write() argument must be str, not bytes') But if i use the cpplint.py from https://github.com/cpplint/cpplint everything goes well.

By comparison I found that it was a matter of how some of the error messages were called by function. So I simply copied the file from https://github.com/cpplint/cpplint and rewrote the old one

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

tkruse commented 1 year ago

As the maintainer of cpplint on pypi, I would recommend NOT merging this PR.

As far as I am aware, Google still has an internal version of cpplint.py which has changes not in this github repository, and merging this PR would make it more difficult to later publish more internal changes (even if it seems increasingly unlikely that this would ever happen). See https://github.com/google/styleguide/pull/528#issuecomment-592315430

As much as I'd like to see the work I have done in https://github.com/cpplint/cpplint be used widely, I'd very much rather keep the hope alive that someday somebody at Google will update the github version of cpplint.py with what Google uses internally.

If Google wanted to abandon the public cpplint.py, it should just be removed from this repo to send people to use https://github.com/cpplint/cpplint, rather than copying back changes from there to here.

Even if for some reason this github repo should incorporate the changes from https://github.com/cpplint/cpplint , then it would be much more reasonable to do so while maintaining the history (it's tricky but possible), so that for each change there is still a separate commit with the context.

Else merging this should have a different commit message than "Error print from https://github.com/cpplint/cpplint fixed", it should rather be the summary of changes form the changelog: https://github.com/cpplint/cpplint/blob/develop/changelog.rst