search

google / styleguide

Style guides for Google-originated open-source projects
https://google.github.io/styleguide/
Apache License 2.0
37.53k stars 13.3k forks source link

cpplint.py write error #751

Open haobo724 opened 1 year ago

haobo724 commented 1 year ago

something wrong with function sys.stderr.write() when I use cpplint.py from git@github.com:google/styleguide.git the console always shows an Error msg: TypeError('write() argument must be str, not bytes') But if i use the cpplint.py from https://github.com/cpplint/cpplint everything goes well.

By comparison I found that it was a matter of how some of the error messages were called by function. So I simply copied the file from https://github.com/cpplint/cpplint and rewrote the old one I also creat a pull issue with title: Error print from https://github.com/cpplint/cpplint fixed #750 https://github.com/google/styleguide/pull/750

Comiclyy commented 1 year ago

Hello, As google most likely has notified you when your pr failed due to unsigned CLA, please sign that as otherwise your pr will not be able to be merged. This issue most likely occurs because google has different internals than cpplint as you mentioned before. Also please refrain from opening an issue and a pr as it causes more problems for devs to go through. Thanks.

haobo724 commented 1 year ago

Hello, As google most likely has notified you when your pr failed due to unsigned CLA, please sign that as otherwise your pr will not be able to be merged. This issue most likely occurs because google has different internals than cpplint as you mentioned before. Also please refrain from opening an issue and a pr as it causes more problems for devs to go through. Thanks.

thank you, now I have signed CLA