search

google / subcommands

Go subcommand library.
Apache License 2.0
749 stars 48 forks source link

go.sum not checked into repository #35

Closed davidzech closed 3 years ago

davidzech commented 3 years ago

Per https://github.com/golang/go/wiki/Modules#should-i-commit-my-gosum-file-as-well-as-my-gomod-file go.sum should be checked into the repository.

The real world ramifications is that go mod tidy will silently break projects using github.com/google/wire via go generate

slewiskelly commented 3 years ago

There are no external dependencies so no go.sum file is generated.

davidzech commented 3 years ago

Yeah that makes sense. Also, making wire stick can be solved by explicitly importing subcommands.