search

google / subpar

Subpar is a utility for creating self-contained python executables. It is designed to work well with Bazel.
Apache License 2.0
567 stars 69 forks source link

[Documentation] Should README setup example use http_archive rather than git_repository? #126

Open wadejensen opened 4 years ago

wadejensen commented 4 years ago

http_archive seems to be the standard method for pulling rules into a WORKSPACE in the bazel ecosystem. Should the README example for this repo

https://github.com/google/subpar/blame/9fae6b63cfeace2e0fb93c9c1ebdc28d3991b16f/README.md#L14-L24

be changed to something like the following?

# Subpar
subpar_version = "35bb9f0092f71ea56b742a520602da9b3638a24f"  # 2.0.0

http_archive(
    name = "subpar",
    sha256 = "34bb4dadd86bbdd3b5736952167e20a1a4c27ff739de11532c4ef77c7c6a68d9",
    strip_prefix = "subpar-{version}".format(version = subpar_version),
    url = "https://github.com/google/subpar/archive/{version}.tar.gz".format(version = subpar_version),
)
samtstern commented 3 years ago

This saved me, you should send a PR to the README!