google / subpar

Subpar is a utility for creating self-contained python executables. It is designed to work well with Bazel.
Apache License 2.0
567 stars 69 forks source link

Shridevinb/windows par #134

Open shridevinb opened 2 years ago

shridevinb commented 2 years ago

This change includes a fix to #39

google-cla[bot] commented 2 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

shridevinb commented 2 years ago

@googlebot I signed it!

google-cla[bot] commented 2 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

shridevinb commented 2 years ago

@googlebot I signed it!

google-cla[bot] commented 2 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

shridevinb commented 2 years ago

@googlebot I signed it!

shridevinb commented 2 years ago

@thundergolfer can you review this change?

thundergolfer commented 2 years ago

@shridevinb I don't think I can. I'm not an owner of this repo so I don't think an approval would count and make the PR mergeable.

shridevinb commented 2 years ago

@brandjon can you review the code?

thundergolfer commented 2 years ago

@shridevinb given

Subpar is currently owned by the maintainers of bazelbuild/rules_python, which depends on it. It is not being actively developed beyond what is needed to keep compatibility with rules_python.

from the repo, I doubt you'll get review, unfortunately. subpar is on life support only for a deprecated part of rules_python. It's effectively unmaintained.