search

google / swift-jupyter

Apache License 2.0
619 stars 90 forks source link

`initing` looks wierd #132

Closed philipturner closed 2 years ago

philipturner commented 2 years ago

and the double percent is incorrect.

initing even went into an issue's title (https://github.com/google/swift-jupyter/issues/130). I will be changing the spelling in my reimplementation of swift-jupyter.

philipturner commented 2 years ago

The double percents are actually correct; they're an escape character in Python. However, a backslash is also an escape character, and there are two ways to do formatted strings! I never faced this ambiguity in Swift.

marcrasi commented 2 years ago

The initing change looks good, but I think that the double-%s are correct so you should reinstate them if you want me to merge this.

philipturner commented 2 years ago

Would it be feasible to note in the README that Swift-Jupyter currently fails to work on Docker and redirect users to Swift-Colab? Or swap out the S4TF toolchain for a Swift release toolchain? It might require a bit of time for troubleshooting, but the latter idea would separate this project from the (currently) archived S4TF.