google / syzkaller

syzkaller is an unsupervised coverage-guided kernel fuzzer
Apache License 2.0
5.29k stars 1.2k forks source link

"pages build and deployment / build (dynamic)" failures #5089

Closed tarasmadan closed 1 month ago

tarasmadan commented 1 month ago

Describe the bug Almost every post-integration build reports "pages build and deployment / build (dynamic) ".

To Reproduce See https://github.com/google/syzkaller/commits/master/ . image

a-nogikh commented 1 month ago

For some reason, it tries to parse and analyze syzlang snippets in our documentation:

2024-07-22T11:27:11.6756405Z   Liquid Exception: Liquid syntax error (line 36): Variable '{{0x800, @ipv4={{0x5, 0x4, 0x0, 0x0, 0x28, 0x0, 0x0, 0x0, 0x6, 0x0, @remote={0xac, 0x14, 0x0, 0xbb}' was not properly terminated with regexp: /\}\}/ in docs/linux/external_fuzzing_network.md
2024-07-22T11:27:11.6774557Z /usr/local/bundle/gems/liquid-4.0.4/lib/liquid/block_body.rb:136:in `raise_missing_variable_terminator': Liquid syntax error (line 36): Variable '{{0x800, @ipv4={{0x5, 0x4, 0x0, 0x0, 0x28, 0x0, 0x0, 0x0, 0x6, 0x0, @remote={0xac, 0x14, 0x0, 0xbb}' was not properly terminated with regexp: /\\}\\}/ (Liquid::SyntaxError)
2
a-nogikh commented 1 month ago

Looks like Liquid is being forced upon us by GitHub: https://docs.github.com/en/contributing/writing-for-github-docs/using-markdown-and-liquid-in-github-docs

The documentation says

If you are using a language that contains curly braces, you will likely need to place {% raw %} and {% endraw %} tags around your code. Since Jekyll 4.0 , you can add render_with_liquid: false in your front matter to disable Liquid entirely for a particular document.

https://jekyllrb.com/docs/liquid/tags/

We actually don't really need Liquid for our project, so perhaps we can somehow pass render_with_liquid: false?

a-nogikh commented 1 month ago

I've set None at https://github.com/google/syzkaller/settings/pages

Hopefully that should help. We don't use GitHub pages anyway.

a-nogikh commented 1 month ago

The problem is gone indeed.