search

google / syzygy

Syzygy Transformation Toolchain
Apache License 2.0
355 stars 59 forks source link

Report previous block details on heap underflow #21

Open sigurasg opened 9 years ago

sigurasg commented 9 years ago

In the last SyzyASAN canary, there are 50 heap underflows reported. From an initial look at this, it's possible that what's really happening is overflow from the preceding block, but we don't seem to report on that block. It would likely be helpful to report the immediately preceding block at least?

sebmarchand commented 9 years ago

Yeah, we could probably use the new Kasko Memory Range functionality to make sure that all the useful data gets included in the minidump (most of the time we already have the content of the previous block, but we don't have its stack traces).

chhamilton commented 9 years ago

Yup, that would be easiest. We can also extend the AsanErrorInfo and crashdata struct if need be to add appropriate new fields (like previous_block and next_block, to be filled out if needed).

On Tue, 25 Aug 2015 at 10:22 Sébastien Marchand notifications@github.com wrote:

Yeah, we could probably use the new Kasko Memory Range functionality to make sure that all the useful data gets included in the minidump (most of the time we already have the content of the previous block, but we don't have its stack traces).

— Reply to this email directly or view it on GitHub https://github.com/google/syzygy/issues/21#issuecomment-134602534.