google / syzygy

Syzygy Transformation Toolchain
Apache License 2.0
355 stars 59 forks source link

Unittests repeat when failed #6

Closed chhamilton closed 9 years ago

chhamilton commented 9 years ago

We currently use the unittest fixture in base/test/run_all_unittests.cc. By default this fixture will repeat failed tests a finite number of times, and consider them as passed if they succeed at any point. This is mainly an attempt to deal with flakiness in Chrome and has the potential to hide real issues in our unittests.

It would be worth hoisting a new unittest runner in syzygy/testing that disables this feature (see syzygy/testing/run_all_unittests_with_large_timeout for an example), and migrate all tests to use it.