Closed aomarks closed 3 years ago
I just tested this out here and it works perfectly for me. Thanks so much for filling in the gaps on this workflow @aomarks it's a huge help!
Oops! I was completely fooled by that code folding. Thanks for answering my questions.
Also threw in a fix to tests relating to chromedriver having updated to Chrome 94 while GitHub Actions is still on Chrome 93.
This PR adds a new
browser.profile
JSON config setting which can be used like this:It also fixes a bug where
addArguments
was not being applied to Firefox, even though it was documented that it was supported.For Chrome, it was previously supported and documented to use
"addArguments": ["user-data-dir=<path>"]
to achieve this same effect, but I found that the equivalent for Firefox ("-profile=<path>"
) caused Selenium to timeout trying to connect to the process. I wasn't able to figure out exactly why this was happening, but I did notice a dedicatedsetProfile
method just for Firefox, which does work. So by adding thebrowser.profile
setting, we now have a way to call this special API, plus the user doesn't need to remember theuser-data-dir
flag in Chrome.Fixes https://github.com/Polymer/tachometer/issues/222
cc @guybedford