Interpret paths relative to config file instead of cwd

google / tachometer

Statistically rigorous benchmark runner for the web

BSD 3-Clause "New" or "Revised" License

671 stars 22 forks source link

Interpret paths relative to config file instead of cwd #237

Closed aomarks closed 2 years ago

aomarks commented 2 years ago

Previously, the server root and the benchmark paths were interpreted relative to the current working directory. This meant that a given config could only ever run from one specific working directory, which was confusing and inconvenient. Now, they are interpreted relative to the config file path itself, so the current directory doesn't matter.

Also:

Update package locks
Remove outdated chromedriver pinning in CI
Upgraded CI to Node 16 and the latest versions of the checkout/node actions

Fixes https://github.com/Polymer/tachometer/issues/176

aomarks commented 2 years ago

Great! The only other place to maybe put a small hint of the usage of root is in the CLI docs: https://github.com/Polymer/tachometer#config-file:~:text=Show%20documentation-,%2D%2Droot,-./

The new changes only apply to the JSON configs, and when you're using a JSON config the --root flag errors (because all the config is expected to be in the JSON file).

aomarks commented 2 years ago

Great! The only other place to maybe put a small hint of the usage of root is in the CLI docs: https://github.com/Polymer/tachometer#config-file:~:text=Show%20documentation-,%2D%2Droot,-./

The new changes only apply to the JSON configs, and when you're using a JSON config the --root flag errors (because all the config is expected to be in the JSON file).

Side note, in general the config file options aren't really properly documented, the README needs a revamp to make this all more clear. But not tackling that right now.