google / taqo-paco

Desktop and new mobile client apps for the Paco user behavior research platform (https://www.pacoapp.com/).
Apache License 2.0
12 stars 10 forks source link

Investigate possibilities for crashing in pal event helper insert event #202

Closed BobEvans closed 11 months ago

BobEvans commented 11 months ago

Server logs show a restart for one participant after the log event "inserting event..."

There is likely a crash in this flow that needs to be guarded against.

T14:35:26.809583+00:00 INFO [SyncService]: Syncing public events complete. 2023-09-19T14:36:16.311160+00:00 INFO [PalEventHelper]: inserting event2023-09-19T15:15:26.659394+00:00 INFO [Main]: Logging service is ready 2023-09-19T15:15:26.661183+00:00 INFO [MachineId]: Machine ID: 84f36828-4ec5-4d7a-8413-326b0bdd2675

BobEvans commented 11 months ago

More evidence, later in the same log

2023-09-19T15:15:28.778500+00:00 INFO [SyncService]: Syncing public events complete. 2023-09-19T15:15:36.693225+00:00 INFO [PalEventHelper]: inserting event2023-09-19T15:54:00.519456+00:00 INFO [Main]: Logging service is ready 2023-09-19T15:54:00.520728+00:00 INFO [MachineId]: Machine ID: 84f36828-4ec5-4d7a-8413-326b0bdd2675 2023-09-19T15:54:00.521214+00:00 INFO [Main]: Server ready

BobEvans commented 11 months ago

This is likely some funky data hitting the allowlist.filterData method. Add more error handling and logging there.