google / taqo-paco

Desktop and new mobile client apps for the Paco user behavior research platform (https://www.pacoapp.com/).
Apache License 2.0
12 stars 7 forks source link

local terminals inside code are not recording events sometimes #215

Open BobEvans opened 1 year ago

BobEvans commented 1 year ago

Expected Behavior

Opening a local terminal inside vscode will also source the .bashrc and log shell commands.

Actual Behavior

Does not set the prompt to have the red ball Does not send events to the pal_event_server.

Steps to Reproduce the Problem

  1. Join an invitation code study with shell tracing
  2. Open vs code
  3. open a terminal
  4. execute any shell command

Specifications

BobEvans commented 1 year ago

It seems this has to do with a setting VS Code, called Enable Shell integration, which injects commands and may or may not load the ~/.bashrc.

It seems that zsh and fish work OK.

BobEvans commented 1 year ago

Unclear what happened. No evidence. But adding if [ -n "$BASH_VERSION" ]; then

include .bashrc if it exists

if [ -f "$HOME/.bashrc" ]; then
    . "$HOME/.bashrc"
fi

fi back into .bash_profile solved the problem in VS Code terminals and in macOS Terminal terminals.

BobEvans commented 1 year ago

On linux, everything works fine.

BobEvans commented 1 year ago

There is also a problem with local fish shells in VS Code. Bug filed: https://github.com/microsoft/vscode/issues/194323