Fix example in the README

google / tarpc

An RPC framework for Rust with a focus on ease of use.

MIT License

3.18k stars 194 forks source link

Fix example in the README #407

Closed cGuille closed 10 months ago

cGuille commented 1 year ago

After following the instructions from the README to replicate the example, I had a few warnings, as well as an error due to a missing tokio feature.

This PR contains the changes I made to fix those few issues.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

tikue commented 1 year ago

Thanks! Should any of these fixes also be applied to https://github.com/google/tarpc/blob/master/tarpc/examples/readme.rs?

cGuille commented 1 year ago

I don't think so:

There is no Cargo.toml in this directory, so the first issue about the missing tokio feature cannot happen.
I could build without warning by using the Cargo.toml of README.md and the sources from tarpc/examples/readme.rs.

So I think it's fine.

tikue commented 1 year ago

Hm, looks like I've got some bitrot to take care of! Will get back to this soon.

tikue commented 10 months ago

Thanks again! Sorry for the delay!

cGuille commented 10 months ago

No worry, thank you!